From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757865AbcDEJjX (ORCPT ); Tue, 5 Apr 2016 05:39:23 -0400 Received: from www.linutronix.de ([62.245.132.108]:37248 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755956AbcDEJjV (ORCPT ); Tue, 5 Apr 2016 05:39:21 -0400 Date: Tue, 5 Apr 2016 11:39:18 +0200 (CEST) From: Anna-Maria Gleixner To: "Suzuki K. Poulose" cc: linux-kernel@vger.kernel.org, rt@linutronix.de, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function call In-Reply-To: <570384DA.6010805@arm.com> Message-ID: References: <1459766569-17237-1-git-send-email-anna-maria@linutronix.de> <570384DA.6010805@arm.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 5 Apr 2016, Suzuki K. Poulose wrote: > On 04/04/16 11:42, Anna-Maria Gleixner wrote: > > Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to > > hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and > > CPU_DOWN_PREPARE are processed on the hotplugged cpu. Due to this SMP > > function calls are no longer required. > > > > Replace smp_call_function_single() with a direct call of > > hw_breakpoint_reset(). To keep the calling convention, interrupts are > > explicitely disabled around the call. > > While you are at it, could you please also fix a similar instance > in arch/arm64/kernel/debug-monitors.c: hw_breakpoint_reset_notify() ? I already sent a patch for it, but I misspelled the arm mailinglist address... I bounced it to the mailinglist. Anna-Maria