From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753262AbcDUS53 (ORCPT ); Thu, 21 Apr 2016 14:57:29 -0400 Received: from www.linutronix.de ([62.245.132.108]:50520 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751662AbcDUS52 (ORCPT ); Thu, 21 Apr 2016 14:57:28 -0400 Date: Thu, 21 Apr 2016 20:55:38 +0200 (CEST) From: Thomas Gleixner To: Borislav Petkov cc: Alexander Shishkin , Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, Arnaldo Carvalho de Melo , Mathieu Poirier Subject: Re: [PATCH v1 2/5] perf/x86/intel/pt: IP filtering register/cpuid bits In-Reply-To: <20160421174813.GA29639@pd.tnic> Message-ID: References: <1461251823-12416-1-git-send-email-alexander.shishkin@linux.intel.com> <1461251823-12416-3-git-send-email-alexander.shishkin@linux.intel.com> <20160421174813.GA29639@pd.tnic> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Apr 2016, Borislav Petkov wrote: > > +#define MSR_IA32_RTIT_ADDR0_A 0x00000580 > > +#define MSR_IA32_RTIT_ADDR0_B 0x00000581 > > +#define MSR_IA32_RTIT_ADDR1_A 0x00000582 > > +#define MSR_IA32_RTIT_ADDR1_B 0x00000583 > > +#define MSR_IA32_RTIT_ADDR2_A 0x00000584 > > +#define MSR_IA32_RTIT_ADDR2_B 0x00000585 > > +#define MSR_IA32_RTIT_ADDR3_A 0x00000586 > > +#define MSR_IA32_RTIT_ADDR3_B 0x00000587 > > So can we not turn msr-index.h a dumping ground for MSRs pls? > > If those are only PT-relevant, why not define them all in pt.h? I have to disagree here. The MSRs itself can really go into msr-index.h while the bit definitions might go elsewhere. What's wrong with having all MSRs at a central place? Thanks, tglx