From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753295AbcEBINE (ORCPT ); Mon, 2 May 2016 04:13:04 -0400 Received: from www.linutronix.de ([62.245.132.108]:40230 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752317AbcEBIM4 (ORCPT ); Mon, 2 May 2016 04:12:56 -0400 Date: Mon, 2 May 2016 10:11:13 +0200 (CEST) From: Thomas Gleixner To: Lianwei Wang cc: Peter Zijlstra , oleg@redhat.com, Ingo Molnar , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH] cpu/hotplug: handle unbalanced hotplug enable/disable In-Reply-To: Message-ID: References: <1461214567-3356-1-git-send-email-lianwei.wang@gmail.com> <20160421105042.GI3408@twins.programming.kicks-ass.net> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Apr 2016, Lianwei Wang wrote: > On Thu, Apr 28, 2016 at 5:44 PM, Thomas Gleixner wrote: > > Wrong. This is the symptom. The root cause is in #1. Therefor you are trying > > to fix the symptom and not the root cause > > > I don't understand why you keep saying that the issue is in the pm > notifier callback. As I told you, the pm notifier return an error(or > NOTIFY_BAD) on purpose to abort the suspend process. This is work as > design. Any driver can abort the suspend process if it is not ready to > suspend. Right. That's not the issue. The issue is that as a consequence we end up with an unbalanced count. So how do we end up with an unbalanced count? That's what needs to be fixed and not worked around. > > I completely understand that you are tyring to put the cart before the horse. > No. Your understanding is wrong. My understanding is very correct. We have a situation which leads to an unbalanced count. Instead of fixing that, you fix up the unbalanced count. Thanks, tglx