From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750887AbcEHQLq (ORCPT ); Sun, 8 May 2016 12:11:46 -0400 Received: from www.linutronix.de ([62.245.132.108]:35049 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750831AbcEHQLo (ORCPT ); Sun, 8 May 2016 12:11:44 -0400 Date: Sun, 8 May 2016 18:09:47 +0200 (CEST) From: Thomas Gleixner To: "Du, Changbin" cc: Andrew Morton , "Paul E. McKenney" , "josh@joshtriplett.org" , Steven Rostedt , Mathieu Desnoyers , "jiangshanlai@gmail.com" , John Stultz , Tejun Heo , LKML Subject: RE: [PATCH] debugobjects: insulate non-fixup logic related to static obj from fixup callbacks In-Reply-To: <0C18FE92A7765D4EB9EE5D38D86A563A05D2DCE6@SHSMSX103.ccr.corp.intel.com> Message-ID: References: <1462576157-14539-1-git-send-email-changbin.du@intel.com> <0C18FE92A7765D4EB9EE5D38D86A563A05D2DCE6@SHSMSX103.ccr.corp.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 8 May 2016, Du, Changbin wrote: > > From: Thomas Gleixner [mailto:tglx@linutronix.de] > > > raw_spin_unlock_irqrestore(&db->lock, flags); > > > /* > > > - * Maybe the object is static. Let the type specific > > > + * Maybe the object is static. Let the type specific > > > * code decide what to do. > > > > Instead of doing white space changes you really want to explain the logic > > here. > > > Comments is in following code. Well. It's a comment, but the code you replace has better explanations about statically initialized objects. This should move here. Thanks, tglx