From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751420AbcEQTgl (ORCPT ); Tue, 17 May 2016 15:36:41 -0400 Received: from www.linutronix.de ([62.245.132.108]:39792 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbcEQTgj (ORCPT ); Tue, 17 May 2016 15:36:39 -0400 Date: Tue, 17 May 2016 21:34:40 +0200 (CEST) From: Thomas Gleixner To: Jiri Olsa cc: Andi Kleen , Peter Zijlstra , linux-kernel@vger.kernel.org, Andi Kleen , x86@kernel.org, Ingo Molnar Subject: Re: [RFC][WARNING] warning in uncore_pci_probe In-Reply-To: <20160517145648.GA28658@krava> Message-ID: References: <20160517145648.GA28658@krava> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 May 2016, Jiri Olsa wrote: > > [ 2.766466] WARNING: CPU: 0 PID: 1 at arch/x86/events/intel/uncore.c:894 uncore_pci_probe+0x2a8/0x2b0 > > I'm booting with nr_cpus=1, which impact physical_to_logical_pkg > setup.. the map will not be initialized because the rest of cpus > is never initialized and set in cpu_present_mask > > it seems to me we should remove the warning, because it's valid to > have only single cpu allowed Single package that is. The package map for cpu 0 is correct, i.e. package 0, but that code tries to init the PCI/uncore for the other packages. So, yes. The WARN_ON() is wrong there. We should just return and be done with it. Thanks, tglx