From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932827AbcERRcT (ORCPT ); Wed, 18 May 2016 13:32:19 -0400 Received: from www.linutronix.de ([62.245.132.108]:43547 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932699AbcERRcR (ORCPT ); Wed, 18 May 2016 13:32:17 -0400 Date: Wed, 18 May 2016 19:30:18 +0200 (CEST) From: Thomas Gleixner To: David Carrillo-Cisneros cc: Peter Zijlstra , Alexander Shishkin , Arnaldo Carvalho de Melo , Ingo Molnar , Vikas Shivappa , Matt Fleming , Tony Luck , Stephane Eranian , Paul Turner , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 03/32] x86/intel,cqm: add CONFIG_INTEL_RDT configuration flag In-Reply-To: <1463007752-116802-4-git-send-email-davidcc@google.com> Message-ID: References: <1463007752-116802-1-git-send-email-davidcc@google.com> <1463007752-116802-4-git-send-email-davidcc@google.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 May 2016, David Carrillo-Cisneros wrote: > Add Intel's PQR as its own build target with no build dependency > on CQM. Add CONFIG_INTEL_RDT as a configuration flag that builds PQR > and related drivers (currently CQM, future: MBM, CAT, CDP). > > Reviewed-by: Stephane Eranian > Signed-off-by: David Carrillo-Cisneros > --- > arch/x86/Kconfig | 7 +++++++ > arch/x86/events/intel/Makefile | 3 ++- > arch/x86/kernel/cpu/Makefile | 4 ++++ > 3 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index a494fa3..52a7edc 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -160,6 +160,13 @@ config X86 > select ARCH_USES_HIGH_VMA_FLAGS if X86_INTEL_MEMORY_PROTECTION_KEYS > select ARCH_HAS_PKEYS if X86_INTEL_MEMORY_PROTECTION_KEYS > > +config INTEL_RDT > + def_bool y > + depends on PERF_EVENTS && CPU_SUP_INTEL > + ---help--- > + Enable Resource Director Technology (RDT) for Intel Xeon Microprocessors. > + RDT includes Cache Monitoring Technology (CMT aka CQM). > + First this wnats to be a module. Second this patch does not compile stand alone. > config INSTRUCTION_DECODER > def_bool y > depends on KPROBES || PERF_EVENTS || UPROBES > diff --git a/arch/x86/events/intel/Makefile b/arch/x86/events/intel/Makefile > index 3660b2c..7e610bf 100644 > --- a/arch/x86/events/intel/Makefile > +++ b/arch/x86/events/intel/Makefile > @@ -1,4 +1,4 @@ > -obj-$(CONFIG_CPU_SUP_INTEL) += core.o bts.o cqm.o This wants to go with the patch which removes cqm.c > +obj-$(CONFIG_CPU_SUP_INTEL) += core.o bts.o > obj-$(CONFIG_CPU_SUP_INTEL) += ds.o knc.o > obj-$(CONFIG_CPU_SUP_INTEL) += lbr.o p4.o p6.o pt.o > obj-$(CONFIG_PERF_EVENTS_INTEL_RAPL) += intel-rapl.o > @@ -7,3 +7,4 @@ obj-$(CONFIG_PERF_EVENTS_INTEL_UNCORE) += intel-uncore.o > intel-uncore-objs := uncore.o uncore_nhmex.o uncore_snb.o uncore_snbep.o > obj-$(CONFIG_PERF_EVENTS_INTEL_CSTATE) += intel-cstate.o > intel-cstate-objs := cstate.o > +obj-$(CONFIG_INTEL_RDT) += cqm.o > diff --git a/arch/x86/kernel/cpu/Makefile b/arch/x86/kernel/cpu/Makefile > index 4a8697f..87e6279 100644 > --- a/arch/x86/kernel/cpu/Makefile > +++ b/arch/x86/kernel/cpu/Makefile > @@ -34,6 +34,10 @@ obj-$(CONFIG_CPU_SUP_CENTAUR) += centaur.o > obj-$(CONFIG_CPU_SUP_TRANSMETA_32) += transmeta.o > obj-$(CONFIG_CPU_SUP_UMC_32) += umc.o > > +ifdef CONFIG_CPU_SUP_INTEL INTEL_RDT already depends on CPU_SUP_INTEL ... > +obj-$(CONFIG_INTEL_RDT) += pqr_common.o > +endif Thanks tglx