From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754039AbcERTLj (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 May 2016 15:11:39 -0400
Received: from www.linutronix.de ([62.245.132.108]:43852 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753697AbcERTLh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 May 2016 15:11:37 -0400
Date: Wed, 18 May 2016 21:09:38 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: David Carrillo-Cisneros <davidcc@google.com>
cc: Peter Zijlstra <peterz@infradead.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        Vikas Shivappa <vikas.shivappa@linux.intel.com>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Tony Luck <tony.luck@intel.com>, Stephane Eranian <eranian@google.com>,
        Paul Turner <pjt@google.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 07/32] perf/x86/intel/cqm: add helpers for per-package
 locking
In-Reply-To: <alpine.DEB.2.11.1605181931540.3851@nanos>
Message-ID: <alpine.DEB.2.11.1605182102370.3851@nanos>
References: <1463007752-116802-1-git-send-email-davidcc@google.com> <1463007752-116802-8-git-send-email-davidcc@google.com> <alpine.DEB.2.11.1605181931540.3851@nanos>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 18 May 2016, Thomas Gleixner wrote:
> On Wed, 11 May 2016, David Carrillo-Cisneros wrote:

> > +	cqm_pkg_id_for_each_online(i)
> > +		mutex_lock_nested(&cqm_pkgs_data[i]->pkg_data_mutex, i);

Peter just pointed out that this will fail when the number of nest levels
exceeds 8. So any system with more than 8 packages will make lockdep explode.

Thanks,

	tglx