From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757447AbcFAGnK (ORCPT ); Wed, 1 Jun 2016 02:43:10 -0400 Received: from www.linutronix.de ([62.245.132.108]:35542 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753621AbcFAGnH (ORCPT ); Wed, 1 Jun 2016 02:43:07 -0400 Date: Wed, 1 Jun 2016 08:40:59 +0200 (CEST) From: Thomas Gleixner To: David Kershner cc: corbet@lwn.net, mingo@redhat.com, hpa@zytor.com, gregkh@linuxfoundation.org, erik.arfvidson@unisys.com, Tim Sell , hofrat@osadl.org, dzickus@redhat.com, jes.sorensen@redhat.com, alexander.curtin@unisys.com, janani.rvchndrn@gmail.com, sudipm.mukherjee@gmail.com, prarit@redhat.com, david.binder@unisys.com, nhorman@redhat.com, dan.j.williams@intel.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, driverdev-devel@linuxdriverproject.org, sparmaintainer@unisys.com Subject: Re: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking In-Reply-To: <1464748013-31309-11-git-send-email-david.kershner@unisys.com> Message-ID: References: <1464748013-31309-1-git-send-email-david.kershner@unisys.com> <1464748013-31309-11-git-send-email-david.kershner@unisys.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 May 2016, David Kershner wrote: > + /* > + * If we're not paused, really enable interrupts. > + * Regardless of whether we are paused, set a flag indicating > + * interrupts should be enabled so when we resume, interrupts > + * will really be enabled. > + */ > + down_write(&devdata->lock_visor_dev); Why is this a rw_semaphore? It's only ever taken with down_write() and it's always the same context. Should be a mutex, right? While at it, please convert the notifier_lock to a mutex as well. Thanks, tglx