From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757532AbcFAGra (ORCPT ); Wed, 1 Jun 2016 02:47:30 -0400 Received: from www.linutronix.de ([62.245.132.108]:35584 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752209AbcFAGr0 (ORCPT ); Wed, 1 Jun 2016 02:47:26 -0400 Date: Wed, 1 Jun 2016 08:45:25 +0200 (CEST) From: Thomas Gleixner To: David Kershner cc: corbet@lwn.net, mingo@redhat.com, hpa@zytor.com, gregkh@linuxfoundation.org, erik.arfvidson@unisys.com, timothy.sell@unisys.com, hofrat@osadl.org, dzickus@redhat.com, jes.sorensen@redhat.com, alexander.curtin@unisys.com, janani.rvchndrn@gmail.com, sudipm.mukherjee@gmail.com, prarit@redhat.com, david.binder@unisys.com, nhorman@redhat.com, dan.j.williams@intel.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, driverdev-devel@linuxdriverproject.org, sparmaintainer@unisys.com, Bryan Thompson Subject: Re: [PATCH v2 13/27] staging: unisys: visorbus: Make visordriver_callback_lock a mutex In-Reply-To: <1464748013-31309-14-git-send-email-david.kershner@unisys.com> Message-ID: References: <1464748013-31309-1-git-send-email-david.kershner@unisys.com> <1464748013-31309-14-git-send-email-david.kershner@unisys.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 May 2016, David Kershner wrote: > From: Bryan Thompson > > visordriver_callback_lock is just a binary semaphore that logically > makes more sense as a mutex. > > Signed-off-by: Bryan Thompson > Signed-off-by: David Kershner > Reviewed-by: Tim Sell > --- > drivers/staging/unisys/include/visorbus.h | 3 ++- > drivers/staging/unisys/visorbus/visorbus_main.c | 10 +++++----- > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/unisys/include/visorbus.h b/drivers/staging/unisys/include/visorbus.h > index 9bb88bb..9da25c0 100644 > --- a/drivers/staging/unisys/include/visorbus.h > +++ b/drivers/staging/unisys/include/visorbus.h > @@ -161,7 +161,8 @@ struct visor_device { > struct timer_list timer; > bool timer_active; > bool being_removed; > - struct semaphore visordriver_callback_lock; > + /* mutex to serialize visor_driver function callbacks */ TBH. I hate these kind of comments. The mutex name is self explaining, right? I rather wish you would have spent time documenting the non obvious parts of the code. Thanks, tglx