From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161065AbcFOQpw (ORCPT <rfc822;w@1wt.eu>);
	Wed, 15 Jun 2016 12:45:52 -0400
Received: from www.linutronix.de ([62.245.132.108]:41004 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753239AbcFOQpt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 15 Jun 2016 12:45:49 -0400
Date: Wed, 15 Jun 2016 18:43:46 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Arjan van de Ven <arjanvandeven@gmail.com>
cc: Eric Dumazet <edumazet@google.com>, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Frederic Weisbecker <fweisbec@gmail.com>, Chris Mason <clm@fb.com>,
        Arjan van de Ven <arjan@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [patch 13/20] timer: Switch to a non cascading wheel
In-Reply-To: <CADyApD3QNoS+dkv_XhzKbk+KQv_JC5p=jXT-=bcWh1xmfyNdQw@mail.gmail.com>
Message-ID: <alpine.DEB.2.11.1606151746270.5839@nanos>
References: <20160613070440.950649741@linutronix.de> <20160613075929.282143900@linutronix.de> <20160613114005.GY30909@twins.programming.kicks-ass.net> <alpine.DEB.2.11.1606131426330.5839@nanos> <20160614101144.GA849@gmail.com> <alpine.DEB.2.11.1606141213300.5839@nanos>
 <CADyApD1L48AVT7D94wYuL89m7V+--rg59GFvHzhHMZ5uhhdaYw@mail.gmail.com> <alpine.DEB.2.11.1606142000150.5839@nanos> <20160614204225.GI30154@twins.programming.kicks-ass.net> <CANn89iKO4BzNOW9HCFdjbQxVbk=cwxFJ1ssRmnX+mfUnA+fD5A@mail.gmail.com>
 <alpine.DEB.2.11.1606151651520.5839@nanos> <CADyApD3QNoS+dkv_XhzKbk+KQv_JC5p=jXT-=bcWh1xmfyNdQw@mail.gmail.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 15 Jun 2016, Arjan van de Ven wrote:
> what would 1 more timer wheel do?

Waste storage space and make the collection of expired timers more expensive.

The selection of the timer wheel properties is combination of:

    1) Granularity 

    2) Storage space

    3) Number of levels to collect

#1 Influences the accuracy of the wheel levels. The worst case error is the
   ratio of the shortest timeout in a level and the granularity of that level.

   Currently I've chosen 12.5%. If we go to 25% worst case, then we increase
   the per level capacity by factor (1 << lvl).

#2 It strikes me a bit silly to waste storage space for esoteric
   outliers. According to the data I collected we have no timers at all
   between 2hrs and 5 days.

#3 The more levels we have the more steps we have when collecting expired
   timers or searching the next expiring timer. It's all bound, but it still
   adds up.

Thanks,

	tglx