From: Thomas Gleixner <tglx@linutronix.de>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Sasha Levin <sasha.levin@oracle.com>, Tejun Heo <tj@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Changbin Du <changbin.du@intel.com>,
giometti@enneenne.com, LKML <linux-kernel@vger.kernel.org>,
syzkaller <syzkaller@googlegroups.com>
Subject: Re: Freeing active kobject in pps_device_destruct
Date: Mon, 27 Jun 2016 15:13:01 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1606271441040.4041@nanos> (raw)
In-Reply-To: <CAOMGZ=E0AdfZfs-w5ZX9gBLmGONtbnntuX7c_E3DXbB=j-OeHQ@mail.gmail.com>
On Sat, 25 Jun 2016, Vegard Nossum wrote:
> On 27 November 2015 at 05:30, Sasha Levin <sasha.levin@oracle.com> wrote:
> > (active state 0) object type: timer_list hint: delayed_work_timer_fn+0x0/0x90
> > [ 1167.394563] Workqueue: events kobject_delayed_cleanup
> > [ 1167.410301] [<ffffffffab7aac4c>] kfree+0x1fc/0x2f0
> > [ 1167.410734] [<ffffffffb1f7a447>] pps_device_destruct+0x107/0x110
> > [ 1167.413495] [<fffffffface715ad>] kobject_delayed_cleanup+0x34d/0x3b0
> > [ 1167.414049] [<ffffffffab39fa37>] process_one_work+0xab7/0x13b0
> > [ 1167.417188] [<ffffffffab3a0c6d>] worker_thread+0x93d/0xd20
> > [ 1167.418782] [<ffffffffab3b34a0>] kthread+0x290/0x2b0
> > [ 1167.422467] [<ffffffffb4a1290f>] ret_from_fork+0x3f/0x70
> ODEBUG: free active (active state 0) object type: timer_list hint:
> delayed_work_timer_fn+0x0/0x50
> [<ffffffff8132c563>] kfree+0x103/0x2f0
> [<ffffffff8163af91>] disk_release+0x141/0x180
> [<ffffffff818bcc5a>] device_release+0x4a/0x100
> [<ffffffff816763ac>] kobject_delayed_cleanup+0x6c/0xb0
> [<ffffffff810f698d>] process_one_work+0x46d/0xa60
> [<ffffffff810f700b>] worker_thread+0x8b/0x730
> [<ffffffff81100fe2>] kthread+0x192/0x1b0
> [<ffffffff81d6240f>] ret_from_fork+0x1f/0x40
> As far as I can tell, it seems like a general problem with
> kobject_delayed_cleanup() OR delayed work handling. debugobjects is
> complaining about the timer used to delay the work is still "active"
> (not as in hasn't fired but as in not destroyed) when disk_release()
State active means: The timer is queued and has not yet fired.
Which is completely confusing because the delayed work will only be processed
after the timer has fired. And when the timer fires it is deactivated in debug
objects before the callback function is invoked.
So it's really puzzling why the debug objects state of the timer would be
ODEBUG_STATE_ACTIVE, which is the only way that the debug objects free check
can trigger.
Confused!
tglx
prev parent reply other threads:[~2016-06-27 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 4:30 Sasha Levin
2016-06-25 18:23 ` Vegard Nossum
2016-06-27 13:13 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1606271441040.4041@nanos \
--to=tglx@linutronix.de \
--cc=changbin.du@intel.com \
--cc=giometti@enneenne.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=syzkaller@googlegroups.com \
--cc=tj@kernel.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®