From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933530AbcGLPVK (ORCPT ); Tue, 12 Jul 2016 11:21:10 -0400 Received: from www.linutronix.de ([62.245.132.108]:34791 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932428AbcGLPVI (ORCPT ); Tue, 12 Jul 2016 11:21:08 -0400 Date: Tue, 12 Jul 2016 17:18:57 +0200 (CEST) From: Thomas Gleixner To: Anna-Maria Gleixner cc: Daniel Lezcano , linux-kernel@vger.kernel.org Subject: Re: [PATCH 44/93] clocksource/drivers/time-armada-370-xp: Convert init function to return error In-Reply-To: Message-ID: References: <577E0BED.3020608@linaro.org> <1467878526-1238-1-git-send-email-daniel.lezcano@linaro.org> <1467878526-1238-44-git-send-email-daniel.lezcano@linaro.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jul 2016, Anna-Maria Gleixner wrote: > On Thu, 7 Jul 2016, Daniel Lezcano wrote: > > + res = armada_370_xp_timer_setup(this_cpu_ptr(armada_370_xp_evt)); > > + if (!res) { > > I think the "!" is a mistake, because armada_370_xp_timer_setup() > returns zero. See delta patch fixing this below. Yes it is wrong. Care to send a proper patch with a proper changelog? Thanks, tglx > 8<------------------- > --- a/drivers/clocksource/time-armada-370-xp.c > +++ b/drivers/clocksource/time-armada-370-xp.c > @@ -342,7 +342,7 @@ static int __init armada_370_xp_timer_co > } > > res = armada_370_xp_timer_setup(this_cpu_ptr(armada_370_xp_evt)); > - if (!res) { > + if (res) { > pr_err("Failed to setup timer"); > return res; > } >