From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754002AbcGLRVi (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jul 2016 13:21:38 -0400
Received: from www.linutronix.de ([62.245.132.108]:35355 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751178AbcGLRVh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jul 2016 13:21:37 -0400
Date: Tue, 12 Jul 2016 19:19:19 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: kernel test robot <xiaolong.ye@intel.com>
cc: lkp@01.org, tipbuild@zytor.com, LKML <linux-kernel@vger.kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, LKML <linux-kernel@vger.kernel.org>,
        Vince Weaver <vincent.weaver@maine.edu>,
        Stephane Eranian <eranian@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Kan Liang <kan.liang@intel.com>, Jiri Olsa <jolsa@redhat.com>,
        Borislav Petkov <bp@suse.de>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Adam Borowski <kilobyte@angband.pl>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Anna-Maria Gleixner <anna-maria@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>
Subject: Re: [perf/x86] 8de4a00661: WARNING: CPU: 0 PID: 1 at
 kernel/locking/mutex-debug.c:80 debug_mutex_unlock+0x20c/0x2b3
In-Reply-To: <alpine.DEB.2.11.1607121839390.4083@nanos>
Message-ID: <alpine.DEB.2.11.1607121916430.4083@nanos>
References: <57851c63.jJgXfR29tgQSoJ3w%xiaolong.ye@intel.com> <alpine.DEB.2.11.1607121839390.4083@nanos>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 12 Jul 2016, Thomas Gleixner wrote:
> On Wed, 13 Jul 2016, kernel test robot wrote:
> > [    1.863354] WARNING: CPU: 0 PID: 1 at kernel/locking/mutex-debug.c:80 debug_mutex_unlock+0x20c/0x2b3
> > [    1.877193] DEBUG_LOCKS_WARN_ON(lock->owner != current)
> > 
> > [    1.979431]  [<ffffffff8167508c>] mutex_unlock+0x9/0xb
> > [    1.979431]  [<ffffffff8167508c>] mutex_unlock+0x9/0xb
> > [    1.990691]  [<ffffffff8105a67f>] cpuhp_store_callbacks+0x5a/0x63
> 
> I have a hard time to figure out how that can happen:
> 
> static void cpuhp_store_callbacks(enum cpuhp_state state,
>                                   const char *name,
>                                   int (*startup)(unsigned int cpu),
>                                   int (*teardown)(unsigned int cpu))
> {
>         /* (Un)Install the callbacks for further cpu hotplug operations */
>         struct cpuhp_step *sp;
> 
>         mutex_lock(&cpuhp_state_mutex);
>  	sp = cpuhp_get_step(state);
> 	sp->startup = startup;
>         sp->teardown = teardown;
>         sp->name = name;
>         mutex_unlock(&cpuhp_state_mutex);
> }
> 
> Confused ....

And printing cpuhp_state_mutex.owner does not reduce the confusion level.

[    0.186490] WTF 1           (null)
>         mutex_lock(&cpuhp_state_mutex);
[    0.186848] WTF 2 ffff8800002a4000
>  	sp = cpuhp_get_step(state);
[    0.187174] WTF 3 ffff8800002a4000

and current is:

[    0.205749] CPU: 0 PID: 1 Comm: swapper 
[    0.207410] task: ffff8800002a4000

/me goes digging deeper