From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755992AbcGZJJy (ORCPT <rfc822;w@1wt.eu>);
	Tue, 26 Jul 2016 05:09:54 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:42801 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753660AbcGZJJw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 26 Jul 2016 05:09:52 -0400
Date: Tue, 26 Jul 2016 11:07:37 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Chen-Yu Tsai <wens@csie.org>
cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clocksource: sun4i: Clear interrupts after stopping
 timer in probe function
In-Reply-To: <CAGb2v65qoKXO8oQZBMumGZ_VM7KR_236wSNJZMd+VdSGTQu_xQ@mail.gmail.com>
Message-ID: <alpine.DEB.2.11.1607261106540.19896@nanos>
References: <1469502119-2344-1-git-send-email-wens@csie.org> <20160726054937.GS7419@lukather> <CAGb2v65qoKXO8oQZBMumGZ_VM7KR_236wSNJZMd+VdSGTQu_xQ@mail.gmail.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 26 Jul 2016, Chen-Yu Tsai wrote:
> On Tue, Jul 26, 2016 at 1:49 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Tue, Jul 26, 2016 at 11:01:59AM +0800, Chen-Yu Tsai wrote:
> >> The bootloader (U-boot) sometimes uses this timer for various delays.
> >> It uses it as a ongoing counter, and does comparisons on the current
> >> counter value. The timer counter is never stopped.
> >>
> >> In some cases when the user interacts with the bootloader, or lets
> >> it idle for some time before loading Linux, the timer may expire,
> >> and an interrupt will be pending. This results in an unexpected
> >> interrupt when the timer interrupt is enabled by the kernel, at
> >> which point the event_handler isn't set yet. This results in a NULL
> >> pointer dereference exception, panic, and no way to reboot.
> >>
> >> Clear any pending interrupts after we stop the timer in the probe
> >> function to avoid this.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >
> > Awesome, thanks!
> >
> > You should put stable in Cc though for this kind of patches.
> 
> AFAIK some maintainers prefer to add it themselves. Not sure about
> clocksource so I left it out.

At least you should tell the maintainer, that you consider this to be stable
material. It's not an obvious stable candidate.

Thanks,

	tglx