From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932653AbcG1Hrh (ORCPT ); Thu, 28 Jul 2016 03:47:37 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:48007 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750946AbcG1Hr2 (ORCPT ); Thu, 28 Jul 2016 03:47:28 -0400 Date: Thu, 28 Jul 2016 09:45:12 +0200 (CEST) From: Thomas Gleixner To: nick cc: Fengguang Wu , Eric Dumazet , LKML , netdev@vger.kernel.org, Satyam Sharma , intel-wired-lan@lists.osuosl.org, Jeff Kirsher , Ye Xiaolong Subject: Re: [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110 In-Reply-To: <8578bb16-cd04-e8a5-c7f4-be061ede95b4@gmail.com> Message-ID: References: <20160726035003.GA15095@wfg-t540p.sh.intel.com> <1469524492.17736.3.camel@edumazet-glaptop3.roam.corp.google.com> <20160726093224.GA10339@wfg-t540p.sh.intel.com> <8578bb16-cd04-e8a5-c7f4-be061ede95b4@gmail.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Jul 2016, nick wrote: > diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c > index f42129d..e1830af 100644 > --- a/drivers/net/ethernet/intel/e1000/e1000_main.c > +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c > @@ -3797,7 +3797,7 @@ static irqreturn_t e1000_intr(int irq, void *data) > hw->get_link_status = 1; > /* guard against interrupt when we're going down */ > if (!test_bit(__E1000_DOWN, &adapter->flags)) > - schedule_delayed_work(&adapter->watchdog_task, 1); > + mod_work(&adapter->watchdog_task, jiffies + 1); And that's not even funny anymore. Are you using a random generator to create these patches?