From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753017AbcEINyh (ORCPT ); Mon, 9 May 2016 09:54:37 -0400 Received: from mail-io0-f176.google.com ([209.85.223.176]:36434 "EHLO mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941AbcEINyg (ORCPT ); Mon, 9 May 2016 09:54:36 -0400 From: Vince Weaver X-Google-Original-From: Vince Weaver Date: Mon, 9 May 2016 09:54:30 -0400 (EDT) X-X-Sender: vince@macbook-air To: Vineet Gupta cc: linux-perf-users@vger.kernel.org, peterz@infradead.org, acme@redhat.com, linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, mingo@kernel.org, vincent.weaver@maine.edu Subject: Re: [RFC 2/2] perf/core: change errno for sampling event not supported in hardware In-Reply-To: <1462786660-2900-3-git-send-email-vgupta@synopsys.com> Message-ID: References: <1462786660-2900-1-git-send-email-vgupta@synopsys.com> <1462786660-2900-3-git-send-email-vgupta@synopsys.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 May 2016, Vineet Gupta wrote: > This allows userspace to identify this case specifically from the > catch all error msg it prints currently. > > This is an ABI change An ABI change which will probably break things. The original change from ENODEV to ENOTSUPP managed to break things although it took four kernel releases before anyone noticed. The usage of ENOTSUPP was my fault, though I feel like at the time I was told that ENOTSUPP is for internal kernel usage and would be converted to EOPNOTSUPP when returning an error to userspace. But now I can't find any sort of reference for that at all, except the fact that /usr/include/x86_64-linux-gnu/bits/errno.h has /* Linux has no ENOTSUP error code. */ # define ENOTSUP EOPNOTSUPP in it... but wait, that's ENOTSUP not ENOTSUPP. Blargh. Vince