From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756331AbcFHOND (ORCPT ); Wed, 8 Jun 2016 10:13:03 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:33901 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754698AbcFHONB (ORCPT ); Wed, 8 Jun 2016 10:13:01 -0400 From: Vince Weaver X-Google-Original-From: Vince Weaver Date: Wed, 8 Jun 2016 10:12:58 -0400 (EDT) X-X-Sender: vince@macbook-air To: hpa@zytor.com, dave.hansen@linux.intel.com, mingo@kernel.org, linux-kernel@vger.kernel.org, acme@redhat.com, peterz@infradead.org, jolsa@redhat.com, eranian@google.com, tglx@linutronix.de, luto@amacapital.net, brgerst@gmail.com, alexander.shishkin@linux.intel.com, bp@alien8.de, torvalds@linux-foundation.org, jacob.jun.pan@linux.intel.com, dave@sr71.net, dvlasenk@redhat.com cc: linux-tip-commits@vger.kernel.org Subject: Re: [tip:perf/core] perf/x86/rapl: Add Skylake server model detection In-Reply-To: Message-ID: References: <20160603001953.38848836@viggo.jf.intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 8 Jun 2016, tip-bot for Jacob Pan wrote: > Commit-ID: 348c5ac6c7dc117e1de095bf07c86c31101d56f3 > Gitweb: http://git.kernel.org/tip/348c5ac6c7dc117e1de095bf07c86c31101d56f3 > Author: Jacob Pan > AuthorDate: Thu, 2 Jun 2016 17:19:53 -0700 > Committer: Ingo Molnar > CommitDate: Wed, 8 Jun 2016 12:06:01 +0200 > > perf/x86/rapl: Add Skylake server model detection > > SKX uses similar RAPL interface as Broadwell server. ... > X86_RAPL_MODEL_MATCH(INTEL_FAM6_SKYLAKE_MOBILE, skl_rapl_init), > X86_RAPL_MODEL_MATCH(INTEL_FAM6_SKYLAKE_DESKTOP, skl_rapl_init), > + X86_RAPL_MODEL_MATCH(INTEL_FAM6_SKYLAKE_X, hsx_rapl_init), code does not match git commit message. The code says that skylake server matches the haswell server. (Yes I know broadwell server apparently matches haswell server too, but you might want to say that in the git commit to avoid confusion). Vince