From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751695AbcFUL6p (ORCPT ); Tue, 21 Jun 2016 07:58:45 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:43527 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751644AbcFUL6l (ORCPT ); Tue, 21 Jun 2016 07:58:41 -0400 Date: Tue, 21 Jun 2016 10:44:11 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Yury Norov CC: , , , , , , , , , , Andrew Pinski Subject: Re: [PATCH 20/27] [AARCH64] Make lp64 and ilp32 directories. In-Reply-To: <1466485631-3532-22-git-send-email-ynorov@caviumnetworks.com> Message-ID: References: <1466485631-3532-1-git-send-email-ynorov@caviumnetworks.com> <1466485631-3532-22-git-send-email-ynorov@caviumnetworks.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Jun 2016, Yury Norov wrote: > From: Andrew Pinski > > The patch makes the ilp32 and lp64 have their own directory under aarch64. > Since ILP32 uses most of the same system calls as LP64 and has a 64bit > off_t, we need make the functions that end in 64 the same as the ones without. > We also need not to special case ioctl or use the already provided mmap.c file. My previous comments at apply. Where are your ABI test baselines? > diff --git a/sysdeps/aarch64/ilp32/Implies b/sysdeps/aarch64/ilp32/Implies > new file mode 100644 > index 0000000..705bc5b > --- /dev/null > +++ b/sysdeps/aarch64/ilp32/Implies > @@ -0,0 +1,6 @@ > +aarch64 > +wordsize-32 > +ieee754/ldbl-128 > +ieee754/dbl-64 > +ieee754/flt-32 > +aarch64/soft-fp You can use ieee754/dbl-64/wordsize-64 here. See my commit b75bc69cdfe5247b2156ce249518f1c1df4d797d. > diff --git a/sysdeps/unix/sysv/linux/aarch64/ilp32/getdents.c b/sysdeps/unix/sysv/linux/aarch64/ilp32/getdents.c The formatting in this file is thoroughly wrong. > diff --git a/sysdeps/unix/sysv/linux/aarch64/ilp32/preadv.c b/sysdeps/unix/sysv/linux/aarch64/ilp32/preadv.c > new file mode 100644 > index 0000000..b5b9994 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/aarch64/ilp32/preadv.c > @@ -0,0 +1 @@ > +/* See preadv.c */ > \ No newline at end of file All files should have final newlines (but with Adhemerval's preadv unification, you shouldn't need this; make the unified version more general if necessary). > diff --git a/sysdeps/unix/sysv/linux/aarch64/ilp32/shlib-versions b/sysdeps/unix/sysv/linux/aarch64/ilp32/shlib-versions > new file mode 100644 > index 0000000..17db764 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/aarch64/ilp32/shlib-versions > @@ -0,0 +1,7 @@ > +DEFAULT GLIBC_2.21 No, GLIBC_2.24 if this gets in by the end of June, GLIBC_2.25 otherwise (since glibc is frozen for release during July). The symbol version is always the version of the first release with the new port. -- Joseph S. Myers joseph@codesourcery.com