From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752118AbcFVKhh (ORCPT ); Wed, 22 Jun 2016 06:37:37 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:37311 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751453AbcFVKhd (ORCPT ); Wed, 22 Jun 2016 06:37:33 -0400 Date: Wed, 22 Jun 2016 10:37:27 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Yury Norov CC: , , , , , , , , , , Andrew Pinski Subject: Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S. In-Reply-To: <20160622060227.GA22466@yury-N73SV> Message-ID: References: <1466485631-3532-1-git-send-email-ynorov@caviumnetworks.com> <1466485631-3532-7-git-send-email-ynorov@caviumnetworks.com> <20160622060227.GA22466@yury-N73SV> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Jun 2016, Yury Norov wrote: > > As well as preprocessor indentation, this is missing spaces after '('; > > check for and fix that issue throughout this patch series. (There are > > only a few cases where a macro is used to construct a type / variable > > name, such as ElfW, where missing the space is more usual.) > > > > -- > > Joseph S. Myers > > joseph@codesourcery.com > > So, you want have it like this? > #ifdef __LP64__ > # define RTLD_START RTLD_START_1( "x", "3", "sp" ) Sorry, before '(' in function and function-like-macro calls, as in standard GNU style. # define RTLD_START RTLD_START_1 ("x", "3", "sp") -- Joseph S. Myers joseph@codesourcery.com