From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752516AbcF1RAd (ORCPT ); Tue, 28 Jun 2016 13:00:33 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:44988 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752173AbcF1RAc (ORCPT ); Tue, 28 Jun 2016 13:00:32 -0400 Date: Tue, 28 Jun 2016 17:00:28 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Yury Norov CC: , , , , , , , , , , , , , , , , , Andrew Pinski Subject: Re: [PATCH 01/23] [AARCH64] define word size for lp64 and ilp32 In-Reply-To: <1467131978-669-2-git-send-email-ynorov@caviumnetworks.com> Message-ID: References: <1467131978-669-1-git-send-email-ynorov@caviumnetworks.com> <1467131978-669-2-git-send-email-ynorov@caviumnetworks.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Jun 2016, Yury Norov wrote: > diff --git a/sysdeps/aarch64/bits/wordsize.h b/sysdeps/aarch64/bits/wordsize.h See what I said in about "make other bits/wordsize.h files define the macro to 0". This patch would break all other architectures (and AArch64 LP64 - you should test build and testsuite for that, as well as ILP32, and confirm that there are no testsuite regressions for LP64). > +/* Copyright (C) 2014 Free Software Foundation, Inc. See what I said in about one-line descriptions before copyright notices. Please check every new file in every patch in the series for this issue. All copyright notices should have ranges of years that end in 2016. -- Joseph S. Myers joseph@codesourcery.com