From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752348AbcF1RNM (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Jun 2016 13:13:12 -0400
Received: from relay1.mentorg.com ([192.94.38.131]:48225 "EHLO
	relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751946AbcF1RNK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Jun 2016 13:13:10 -0400
Date: Tue, 28 Jun 2016 17:13:07 +0000
From: Joseph Myers <joseph@codesourcery.com>
X-X-Sender: jsm28@digraph.polyomino.org.uk
To: Yury Norov <ynorov@caviumnetworks.com>
CC: <libc-alpha@sourceware.org>, <linux-kernel@vger.kernel.org>,
        <arnd@arndb.de>, <catalin.marinas@arm.com>, <marcus.shawcroft@arm.com>,
        <philb@gnu.org>, <davem@davemloft.net>, <szabolcs.nagy@arm.com>,
        <maxim.kuvyrkov@linaro.org>, <pinskia@gmail.com>,
        <bamvor.zhangjian@huawei.com>, <schwab@suse.de>, <fweimer@redhat.com>,
        <Prasun.Kapoor@cavium.com>, <cmetcalf@mellanox.com>,
        <hjl.tools@gmail.com>, <adhemerval.zanella@linaro.org>,
        Yury Norov <yury.norov@gmail.com>
Subject: Re: [PATCH 17/23] [AARCH64] ILP32: introduce syscalls that pass
 off_t
In-Reply-To: <1467131978-669-18-git-send-email-ynorov@caviumnetworks.com>
Message-ID: <alpine.DEB.2.20.1606281711290.25214@digraph.polyomino.org.uk>
References: <1467131978-669-1-git-send-email-ynorov@caviumnetworks.com> <1467131978-669-18-git-send-email-ynorov@caviumnetworks.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 28 Jun 2016, Yury Norov wrote:

> ILP32 has 64-bit off_t, to follow modern requirements.
> But kernel clears top-halves of input registers. It means
> we have to pass corresponding arguments in a pair, like
> aarch32 does. In this patch all affected syscalls are redefined.
> Most of them are taken from arm code.

Please follow the spirit of Adhemerval's recent work.  Determine the 
appropriate abstractions for the architecture differences for these 
syscalls, and set up unified implementations used on all architectures, 
rather than increasing the number of architecture-specific variants.

> +#ifdef __ILP32__
> +/* Define this if your 32-bit syscall API requires 64-bit register
> +   pairs to start with an even-number register.  */
> +#define __ASSUME_ALIGNED_REGISTER_PAIRS	1
> +#endif /* __ILP32__ */

Preprocessor indentation.

-- 
Joseph S. Myers
joseph@codesourcery.com