From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752506AbcF1RPT (ORCPT ); Tue, 28 Jun 2016 13:15:19 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:48573 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752092AbcF1RPR (ORCPT ); Tue, 28 Jun 2016 13:15:17 -0400 Date: Tue, 28 Jun 2016 17:15:13 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Yury Norov CC: , , , , , , , , , , , , , , , , , Yury Norov Subject: Re: [PATCH 18/23] [AARCH64] ILP32: support stat syscall family In-Reply-To: <1467131978-669-19-git-send-email-ynorov@caviumnetworks.com> Message-ID: References: <1467131978-669-1-git-send-email-ynorov@caviumnetworks.com> <1467131978-669-19-git-send-email-ynorov@caviumnetworks.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org still applies. Unify implementations instead of proliferating variants. Also, much of the formatting is way off the GNU Coding Standards (e.g. indentation that's not two-column, "{" not on a line by itself), and you're missing descriptions as first lines of many new files. -- Joseph S. Myers joseph@codesourcery.com