From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752327AbcF1Rsu (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Jun 2016 13:48:50 -0400
Received: from relay1.mentorg.com ([192.94.38.131]:53924 "EHLO
	relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751952AbcF1Rst (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Jun 2016 13:48:49 -0400
Date: Tue, 28 Jun 2016 17:30:52 +0000
From: Joseph Myers <joseph@codesourcery.com>
X-X-Sender: jsm28@digraph.polyomino.org.uk
To: Yury Norov <ynorov@caviumnetworks.com>
CC: <libc-alpha@sourceware.org>, <linux-kernel@vger.kernel.org>,
        <arnd@arndb.de>, <catalin.marinas@arm.com>, <marcus.shawcroft@arm.com>,
        <philb@gnu.org>, <davem@davemloft.net>, <szabolcs.nagy@arm.com>,
        <maxim.kuvyrkov@linaro.org>, <pinskia@gmail.com>,
        <bamvor.zhangjian@huawei.com>, <schwab@suse.de>, <fweimer@redhat.com>,
        <Prasun.Kapoor@cavium.com>, <cmetcalf@mellanox.com>,
        <hjl.tools@gmail.com>, <adhemerval.zanella@linaro.org>,
        Andrew Pinski <apinski@cavium.com>
Subject: Re: [PATCH 01/23] [AARCH64] define word size for lp64 and ilp32
In-Reply-To: <alpine.DEB.2.20.1606281657540.25214@digraph.polyomino.org.uk>
Message-ID: <alpine.DEB.2.20.1606281729100.25214@digraph.polyomino.org.uk>
References: <1467131978-669-1-git-send-email-ynorov@caviumnetworks.com> <1467131978-669-2-git-send-email-ynorov@caviumnetworks.com> <alpine.DEB.2.20.1606281657540.25214@digraph.polyomino.org.uk>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 28 Jun 2016, Joseph Myers wrote:

> On Tue, 28 Jun 2016, Yury Norov wrote:
> 
> > diff --git a/sysdeps/aarch64/bits/wordsize.h b/sysdeps/aarch64/bits/wordsize.h
> 
> See what I said in 
> <https://sourceware.org/ml/libc-alpha/2016-06/msg00786.html> about "make 
> other bits/wordsize.h files define the macro to 0".  This patch would 
> break all other architectures (and AArch64 LP64 - you should test build 
> and testsuite for that, as well as ILP32, and confirm that there are no 
> testsuite regressions for LP64).

(Actually, for LP64, if you can confirm that the installed stripped shared 
libraries are byte-for-byte identical before and after the patch series, 
then a testsuite run is unnecessary.  But you still need to run the 
testsuite for ILP32, and justify any failures there, and if the LP64 
binaries aren't byte-for-byte identical, you should justify why they 
aren't.)

-- 
Joseph S. Myers
joseph@codesourcery.com