From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752659AbcF1Uiz (ORCPT ); Tue, 28 Jun 2016 16:38:55 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:46302 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752604AbcF1Uiy (ORCPT ); Tue, 28 Jun 2016 16:38:54 -0400 Date: Tue, 28 Jun 2016 20:38:47 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Yury Norov CC: , , , , , , , , , , , , , , , , Subject: Re: [PATCH 23/23] [AARCH64] Take utmp{,x}.h from s390 port In-Reply-To: <20160628175107.GA2262@yury-N73SV> Message-ID: References: <1467131978-669-1-git-send-email-ynorov@caviumnetworks.com> <1467131978-669-24-git-send-email-ynorov@caviumnetworks.com> <20160628175107.GA2262@yury-N73SV> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Jun 2016, Yury Norov wrote: > > You can't #include installed headers from other ports like this; it > > wouldn't work when using an installed library. > > > > -- > > Joseph S. Myers > > joseph@codesourcery.com > > So I should copy? Hmm... Yes, unless you can develop an additional abstraction to describe the differences between architectures, so that all architectures can share the same bits/utmp.h and bits/utmpx.h and there's only a smaller header that needs copying. -- Joseph S. Myers joseph@codesourcery.com