From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750728AbcGTEKO (ORCPT ); Wed, 20 Jul 2016 00:10:14 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:33305 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbcGTEKM (ORCPT ); Wed, 20 Jul 2016 00:10:12 -0400 Date: Wed, 20 Jul 2016 00:09:22 -0400 (EDT) From: Nicolas Pitre To: Geert Uytterhoeven cc: Greg Ungerer , Linux FS Devel , "linux-kernel@vger.kernel.org" , Alexander Viro , David Howells Subject: Re: [PATCH v2 01/10] binfmt_flat: assorted cleanups In-Reply-To: Message-ID: References: <1468812716-30537-1-git-send-email-nicolas.pitre@linaro.org> <1468812716-30537-2-git-send-email-nicolas.pitre@linaro.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Jul 2016, Geert Uytterhoeven wrote: > On Tue, Jul 19, 2016 at 6:52 AM, Greg Ungerer wrote: > > Seeing as you have modified quite a few printk calls is it worth > > while annotating them with appropriate KERN_ERR, KERN_INFO, etc? > > You mean pr_err(), pr_info(), ... ;-) Done. Included in v3. Nicolas