From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758270AbcHDKah (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Aug 2016 06:30:37 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:35663 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753291AbcHDKab (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Aug 2016 06:30:31 -0400
Date: Thu, 4 Aug 2016 12:05:35 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Sebastian Frias <sf84@laposte.net>
cc: Grant Likely <grant.likely@secretlab.ca>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Jason Cooper <jason@lakedaemon.net>,
        LKML <linux-kernel@vger.kernel.org>, Mason <slash.tmp@free.fr>
Subject: Re: [PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell()
In-Reply-To: <57A063B8.5050209@laposte.net>
Message-ID: <alpine.DEB.2.20.1608041146540.5547@nanos>
References: <57A063B8.5050209@laposte.net>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2 Aug 2016, Sebastian Frias wrote:

> Use IRQ_TYPE_SENSE_MASK on irq_domain_xlate_onetwocell()
> 
> According to the xlate() callback definition, the 'out_type' parameter
> needs to be the "linux irq type". A mask for such bits exists,
> IRQ_TYPE_SENSE_MASK, and as a matter of fact it is used in
> irq_domain_xlate_twocell(), use it for irq_domain_xlate_onetwocell() as
> well.
> 
> Fixes: 16b2e6e2f31d ("irq_domain: Create common xlate functions that device
> drivers can use")

You seem to be obsessed by adding "Fixes" tags and 'Fix' to the $subject, but
your changelog just babbles about making the code the same as in
irq_domain_xlate_twocell() and avoids carefully to explain what is broken,
what consequences that has and what the fix is.

Now if you look at the call site which uses the xlate functions then you'll
notice that we have a sanity check there already:

        if (irq_domain_translate(domain, fwspec, &hwirq, &type))
                return 0;
        /*
         * WARN if the irqchip returns a type with bits
         * outside the sense mask set and clear these bits.
         */
        if (WARN_ON(type & ~IRQ_TYPE_SENSE_MASK))
                type &= IRQ_TYPE_SENSE_MASK;

So we better remove the masking in the xlate functions completely and let all
the offending device trees trip over the warning so they get eventually fixed.

Thanks,

	tglx