From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964843AbcHDOaf (ORCPT ); Thu, 4 Aug 2016 10:30:35 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:36368 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933897AbcHDOac (ORCPT ); Thu, 4 Aug 2016 10:30:32 -0400 Date: Thu, 4 Aug 2016 16:03:40 +0200 (CEST) From: Thomas Gleixner To: Sebastian Frias cc: Grant Likely , Marc Zyngier , Jason Cooper , LKML , Mason Subject: Re: [PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell() In-Reply-To: <57A31994.7030503@laposte.net> Message-ID: References: <57A063B8.5050209@laposte.net> <57A31994.7030503@laposte.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 4 Aug 2016, Sebastian Frias wrote: > On 08/04/2016 12:05 PM, Thomas Gleixner wrote: > (for what is worth, my patch was based on a recent 4.7 that does not has the > code you mention above) In future, please always check against mainline or the head of the relevant maintainer tree. > > So we better remove the masking in the xlate functions completely and let all > > the offending device trees trip over the warning so they get eventually fixed. > > That's fine by me. > If you want I can submit a patch that does what you want (if so, should I use > "fixes" or not?), let me know. If it is broken then it wants a fixes tag plus an explanation WHY it is broken, what consequences the breakage has etc. If it's just a regular code improvement then not. Decide yourself. Thanks, tglx