From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756946AbcHWCyg (ORCPT <rfc822;w@1wt.eu>);
        Mon, 22 Aug 2016 22:54:36 -0400
Received: from mail-it0-f49.google.com ([209.85.214.49]:37757 "EHLO
        mail-it0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751168AbcHWCyf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 Aug 2016 22:54:35 -0400
From: Vince Weaver <vincent.weaver@maine.edu>
X-Google-Original-From: Vince Weaver <vince@maine.edu>
Date: Mon, 22 Aug 2016 22:54:32 -0400 (EDT)
X-X-Sender: vince@macbook-air
To: Vince Weaver <vincent.weaver@maine.edu>
cc: Huang Rui <ray.huang@amd.com>, Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org, Borislav Petkov <bp@suse.de>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: perf: fuzzer crashes immediately on AMD system
In-Reply-To: <alpine.DEB.2.20.1608222057360.29115@macbook-air>
Message-ID: <alpine.DEB.2.20.1608222250120.29115@macbook-air>
References: <alpine.DEB.2.20.1608181025160.19862@macbook-air> <alpine.DEB.2.20.1608181046120.19862@macbook-air> <20160819100130.GD10121@twins.programming.kicks-ass.net> <20160822111631.GA25844@hr-amur2> <alpine.DEB.2.20.1608222057360.29115@macbook-air>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > > > 
> > > > 	perf stat -a -e amd_nb/config=0x37,config1=0x20/ /bin/ls
> 	amd_uncore_find_online_sibling()
> function is broken. 

and that's the problem.  uncore_find_online_sibling() does all kinds of 
wrong things including sticking active uncore structures in 
uncore->free_when_cpu_online

Then uncore_online() comes along and frees those structures.

Then some other part of the kernel comes and re-uses the free'd data.

Then when we try to start an event, all of the fields are invalid because 
the uncore pointer is pointing to re-used data.

I don't have a patch because I am not 100% clear on what 
uncore_find_online_sibling() is doing in the first place.

Vince