From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758691AbcHYNXR (ORCPT <rfc822;w@1wt.eu>);
        Thu, 25 Aug 2016 09:23:17 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:34378 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1758594AbcHYNXQ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 25 Aug 2016 09:23:16 -0400
Date: Thu, 25 Aug 2016 15:20:59 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Nicolai Stange <nicstange@gmail.com>
cc: John Stultz <john.stultz@linaro.org>, linux-kernel@vger.kernel.org
Subject: Re: [RFC v4 14/22] clockevents: clockevents_program_event(): turn
 clc into unsigned long
In-Reply-To: <20160822233320.4548-15-nicstange@gmail.com>
Message-ID: <alpine.DEB.2.20.1608251519080.5714@nanos>
References: <20160822233320.4548-1-nicstange@gmail.com> <20160822233320.4548-15-nicstange@gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 23 Aug 2016, Nicolai Stange wrote:

> Right now, being of type unsigned long long, the clc local variable in
> clockevents_program_event() is unnecessarily wide as it gets cast to
> unsigned long anyway.

Congrats! You just broke 32bit systems. When delta is sufficiently large then
the mult overflows....
 
Thanks,

	tglx