From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752388AbcIBNQB (ORCPT ); Fri, 2 Sep 2016 09:16:01 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:54040 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750859AbcIBNP6 (ORCPT ); Fri, 2 Sep 2016 09:15:58 -0400 Date: Fri, 2 Sep 2016 15:13:31 +0200 (CEST) From: Thomas Gleixner To: "Ghannam, Yazen" cc: "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Borislav Petkov Subject: RE: [PATCH] x86/AMD: Fix Socket ID for LLC topology for AMD Fam17h systems In-Reply-To: Message-ID: References: <1472674900-60688-1-git-send-email-Yazen.Ghannam@amd.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2 Sep 2016, Ghannam, Yazen wrote: > > > The Socket ID is ApicId[bits] on Fam17h systems. > > > > > > Change substraction to logical AND when extracting socket_id > > > from c->apicid. > > > > So Fam17h will only ever have 2 sockets, right? > > > > This is the decoding of the ApicId shown in our latest Programming > Reference. I have no idea what your latest reference manual says as it seems to be not yet public. > However, I can remove the "& 1" if you think it'll be better. I's not about what I think is better. I asked the obvious question whether Fam17h will only ever have two sockets, because your patch limits it hard to that. Care to answer that very question instead of handwaving about your interpretation of a secret manual? Thanks, tglx