From: Thomas Gleixner <tglx@linutronix.de>
To: Sebastian Frias <sf84@laposte.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
Jason Cooper <jason@lakedaemon.net>,
LKML <linux-kernel@vger.kernel.org>, Mason <slash.tmp@free.fr>
Subject: Re: [PATCH 1/2] genirq: Generic chip: add irq_unmap_generic_chip
Date: Fri, 2 Sep 2016 17:12:44 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609021706140.5647@nanos> (raw)
In-Reply-To: <579F5C5A.2070507@laposte.net>
On Mon, 1 Aug 2016, Sebastian Frias wrote:
> NOTE: While the proposed unmap() function attempts to undo as much things
> as done by the map() function, I did not find a way to undo the following:
>
> a) irq_gc_init_mask_cache(gc, dgc->gc_flags)
You can't undo that. Because that represents the mask cache of the irq chip
and that is required to be consistent over the life time of the irq
chip.
Unmapping does not make the generic chip and the underlying irqchip go
away.
> b) irq_set_lockdep_class(virq, &irq_nested_lock_class)
No point in undoing that. The irq descriptor is released on unmap.
> c) irq_modify_status(virq, dgc->irq_flags_to_clear, dgc->irq_flags_to_set)
See b)
Thanks,
tglx
next prev parent reply other threads:[~2016-09-02 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 14:27 Sebastian Frias
2016-08-12 10:39 ` Sebastian Frias
2016-09-02 15:12 ` Thomas Gleixner [this message]
2016-09-02 15:36 ` Sebastian Frias
2016-09-02 16:14 ` [tip:irq/core] genirq/generic_chip: Add irq_unmap callback tip-bot for Sebastian Frias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609021706140.5647@nanos \
--to=tglx@linutronix.de \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=sf84@laposte.net \
--cc=slash.tmp@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®