From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932337AbcIBT3g (ORCPT <rfc822;w@1wt.eu>);
        Fri, 2 Sep 2016 15:29:36 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:54982 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932188AbcIBT3f (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Sep 2016 15:29:35 -0400
Date: Fri, 2 Sep 2016 21:26:51 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
cc: Chen Yu <yu.c.chen@intel.com>, x86@kernel.org,
        John Stultz <john.stultz@linaro.org>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org,
        Xunlei Pang <xlpang@redhat.com>, "3.17+" <stable@vger.kernel.org>,
        Zhang Rui <rui.zhang@intel.com>, linux-pm@vger.kernel.org
Subject: Re: [PATCH][RFC v5] timekeeping: Ignore the bogus sleep time if
 pm_trace is enabled
In-Reply-To: <4130556.MNmyvLDyHH@vostro.rjw.lan>
Message-ID: <alpine.DEB.2.20.1609022119160.5647@nanos>
References: <1472402439-1146-1-git-send-email-yu.c.chen@intel.com> <4130556.MNmyvLDyHH@vostro.rjw.lan>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 31 Aug 2016, Rafael J. Wysocki wrote:
> On Monday, August 29, 2016 12:40:39 AM Chen Yu wrote:
> > +
> > +	/*
> > +	 * Make rtc-based persistent clock unusable
> > +	 * if pm_trace is enabled, only take effect
> > +	 * for timekeeping_suspend/resume.
> > +	 */
> > +	if (pm_trace_is_enabled() &&
> > +	    x86_platform.get_wallclock == mach_get_cmos_time) {
> > +		ts->tv_sec = 0;
> > +		ts->tv_nsec = 0;
> > +	}
> 
> I'm not sure about this.  Looks hackish.

Indeed. Can't you just keep track that pm_trace fiddled with the cmos clock
and then discard the value either in the core or in mach_get_cmos_time()

Thanks,

	tglx