From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934855AbcIFKWo (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Sep 2016 06:22:44 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:34736 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933970AbcIFKWl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Sep 2016 06:22:41 -0400
Date: Tue, 6 Sep 2016 12:20:09 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Tomasz Nowicki <tn@semihalf.com>
cc: marc.zyngier@arm.com, jason@lakedaemon.net, rjw@rjwysocki.net,
        helgaas@kernel.org, rafael@kernel.org, Lorenzo.Pieralisi@arm.com,
        will.deacon@arm.com, catalin.marinas@arm.com, hanjun.guo@linaro.org,
        shijie.huang@arm.com, robert.richter@caviumnetworks.com,
        mw@semihalf.com, linux-pci@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linaro-acpi@lists.linaro.org,
        andrea.gallo@linaro.org, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, al.stone@linaro.org,
        graeme.gregory@linaro.org, ddaney.cavm@gmail.com, okaya@codeaurora.org
Subject: Re: [PATCH V10 2/8] ACPI: Add new IORT functions to support MSI
 domain handling
In-Reply-To: <1473152938-17388-3-git-send-email-tn@semihalf.com>
Message-ID: <alpine.DEB.2.20.1609061219230.5647@nanos>
References: <1473152938-17388-1-git-send-email-tn@semihalf.com> <1473152938-17388-3-git-send-email-tn@semihalf.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 6 Sep 2016, Tomasz Nowicki wrote:
> +/**
> + * iort_get_device_domain() - Find MSI domain related to a device
> + * @dev: The device.
> + * @req_id: Requester ID for the device.
> + *
> + * Returns: the MSI domain for this device, NULL otherwise
> + */
> +struct irq_domain *iort_get_device_domain(struct device *dev, u32 req_id)
> +{
> +	static struct fwnode_handle *handle;

static ??????

> +	int its_id;
> +
> +	if (iort_dev_find_its_id(dev, req_id, 0, &its_id))
> +		return NULL;
> +
> +	handle = iort_find_domain_token(its_id);

You reevaluate that on every call.

Thanks,

	tglx