From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758836AbcIHKQ4 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 8 Sep 2016 06:16:56 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:43353 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753261AbcIHKQz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Sep 2016 06:16:55 -0400
Date: Thu, 8 Sep 2016 12:14:12 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Fenghua Yu <fenghua.yu@intel.com>
cc: "H. Peter Anvin" <h.peter.anvin@intel.com>,
        Ingo Molnar <mingo@elte.hu>, Tony Luck <tony.luck@intel.com>,
        Peter Zijlstra <peterz@infradead.org>, Tejun Heo <tj@kernel.org>,
        Borislav Petkov <bp@suse.de>, Stephane Eranian <eranian@google.com>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        David Carrillo-Cisneros <davidcc@google.com>, Shaohua Li <shli@fb.com>,
        Ravi V Shankar <ravi.v.shankar@intel.com>,
        Vikas Shivappa <vikas.shivappa@linux.intel.com>,
        Sai Prakhya <sai.praneeth.prakhya@intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH v2 13/33] Define CONFIG_INTEL_RDT
In-Reply-To: <1473328647-33116-14-git-send-email-fenghua.yu@intel.com>
Message-ID: <alpine.DEB.2.20.1609081208390.5647@nanos>
References: <1473328647-33116-1-git-send-email-fenghua.yu@intel.com> <1473328647-33116-14-git-send-email-fenghua.yu@intel.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 8 Sep 2016, Fenghua Yu wrote:
> From: Vikas Shivappa <vikas.shivappa@linux.intel.com>

This changelog is still utter crap.

> CONFIG_INTEL_RDT is defined.

We know already from $subject that CONFIG_INTEL_RDT is introduced.

>                              The option provides support for resource
> allocation which is a sub-feature of Intel Resource Director Technology
> (RDT).

The config switch says:
 
> +config INTEL_RDT
> +	bool "Intel Resource Director Technology support"

So what? Is this now resource allocation or resource director or does the
actual stuff introduce something completely different?

> +	default n
> +	depends on X86_64 && CPU_SUP_INTEL

Why is this 64bit only? The changelog and/or the help text should tell
that.

> +	help
> +	  This option provides support for resource allocation which is a
> +	  sub-feature of Intel Resource Director Technology(RDT).

Sure and you repeat the changelog nonsense here again.

> +	  Current implementation supports L3 cache allocation.
> +	  Using this feature a user can specify the amount of L3 cache space
> +	  into which an application can fill.

Sigh

	tglx