From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752119AbcIIOl3 (ORCPT ); Fri, 9 Sep 2016 10:41:29 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:49070 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750833AbcIIOl1 (ORCPT ); Fri, 9 Sep 2016 10:41:27 -0400 Date: Fri, 9 Sep 2016 16:38:45 +0200 (CEST) From: Thomas Gleixner To: Robin Murphy cc: joro@8bytes.org, will.deacon@arm.com, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com, jean-philippe.brucker@arm.com, punit.agrawal@arm.com, thunder.leizhen@huawei.com, eric.auger@redhat.com, Jason Cooper , Marc Zyngier , linux-kernel@vger.kernel.org Subject: Re: [PATCH v6.1] iommu/dma: Add support for mapping MSIs In-Reply-To: <33fb440d91a5fe8c3e7dc8a5e12d83a5253911dd.1473242018.git.robin.murphy@arm.com> Message-ID: References: <2da5fca62886afd46cd2a5f7da1da872ee4a833d.1473173789.git.robin.murphy@arm.com> <33fb440d91a5fe8c3e7dc8a5e12d83a5253911dd.1473242018.git.robin.murphy@arm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 7 Sep 2016, Robin Murphy wrote: > - Rework map_page() helper function plus insane lookup logic into > straightforward get_page() helper > - Use phys_addr_t to further simplify address matching > - Fix the bit where I neglected to actually round the doorbell > address to a page boundary (oops!) > - Make the locking hardirq-safe to satisfy lockdep That looks way better. Acked-by: Thomas Gleixner