From: Thomas Gleixner <tglx@linutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: Binoy Jayan <binoy.jayan@linaro.org>,
Carsten Emde <C.Emde@osadl.org>,
"Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Daniel Wagner <daniel.wagner@bmw-carit.de>,
Arnd Bergmann <arnd@arndb.de>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Masami <masami.hiramatsu@linaro.org>
Subject: Re: [PATCH v6 4/4] tracing: Histogram for delayed hrtimer offsets
Date: Sat, 10 Sep 2016 08:10:59 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609100807300.9305@nanos> (raw)
In-Reply-To: <20160909171004.GU27946@sirena.org.uk>
On Fri, 9 Sep 2016, Mark Brown wrote:
> On Thu, Sep 08, 2016 at 03:09:36PM +0530, Binoy Jayan wrote:
> > On 8 September 2016 at 12:40, Thomas Gleixner <tglx@linutronix.de> wrote:
> > > On Wed, 7 Sep 2016, Binoy Jayan wrote:
>
> > >> +#ifdef CONFIG_DELAYED_TIMER_OFFSETS_HIST
> > >> + ktime_t praecox;
> > >> +#endif
>
> > > And of course documenting new struct members is optional, correct? I'm
> > > really looking forward for the explanation of that variable name.
>
> > It marks the start time when a process is scheduled to be woken up as
> > the result
> > of expiry of the hrtimer. Will be mentioning it in the comments.
>
> Even with an appropriate comment I'm not sure that the term praecox is
> sufficiently widely understood to be a clear variable name.
For those who understand it and know the main use case of this term it
certainly has entertainment value.
Thanks,
tglx
prev parent reply other threads:[~2016-09-10 6:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 11:13 [PATCH v6 0/4] *** Latency histograms - IRQSOFF,PREEMPTOFF, Delayed HRTIMERS *** Binoy Jayan
2016-09-07 11:13 ` [PATCH v6 1/4] tracing: Deference pointers without RCU checks Binoy Jayan
2016-09-08 6:46 ` Masami Hiramatsu
2016-09-07 11:13 ` [PATCH v6 2/4] tracing: Add hist trigger support for generic fields Binoy Jayan
2016-09-07 13:39 ` kbuild test robot
2016-09-07 11:13 ` [PATCH v6 3/4] tracing: Add trace_irqsoff tracepoints Binoy Jayan
2016-09-07 16:42 ` Thomas Gleixner
2016-09-08 5:20 ` Daniel Wagner
2016-09-08 6:31 ` Thomas Gleixner
2016-09-08 8:06 ` Thomas Gleixner
2016-09-12 13:50 ` Steven Rostedt
2016-09-14 6:52 ` Binoy Jayan
2016-09-14 9:42 ` Thomas Gleixner
2016-09-07 11:13 ` [PATCH v6 4/4] tracing: Histogram for delayed hrtimer offsets Binoy Jayan
2016-09-08 6:56 ` Masami Hiramatsu
2016-09-08 7:10 ` Thomas Gleixner
2016-09-08 9:39 ` Binoy Jayan
2016-09-09 13:30 ` Thomas Gleixner
2016-09-23 14:20 ` Carsten Emde
2016-09-09 17:10 ` Mark Brown
2016-09-10 6:10 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609100807300.9305@nanos \
--to=tglx@linutronix.de \
--cc=C.Emde@osadl.org \
--cc=arnd@arndb.de \
--cc=binoy.jayan@linaro.org \
--cc=broonie@kernel.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®