From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752200AbcIJGht (ORCPT ); Sat, 10 Sep 2016 02:37:49 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:50752 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750861AbcIJGhs (ORCPT ); Sat, 10 Sep 2016 02:37:48 -0400 Date: Sat, 10 Sep 2016 08:35:18 +0200 (CEST) From: Thomas Gleixner To: Prarit Bhargava cc: linux-kernel@vger.kernel.org, Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Rafael Aquini , "Peter Zijlstra (Intel)" , Andy Lutomirski , Len Brown , lenb@kernel.org Subject: Re: [PATCH] Add additional Intel CPU models to crystal_khz whitelist In-Reply-To: <1473434283-11475-1-git-send-email-prarit@redhat.com> Message-ID: References: <1473434283-11475-1-git-send-email-prarit@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Sep 2016, Prarit Bhargava wrote: > In commit aa297292d708 ("x86/tsc: Enumerate SKL cpu_khz and tsc_khz via You cite a commit here, which is nice. If you look at the commit message then you will notice that _before_ the sentence describing the commit there is a prefix, which denotes the subsystem to which this patch applies. But you insist on sending patches w/o a prefix. Can you please stop this? It's annoying because I have to figure out where the patch belongs to and have to edit the subject line before applying the patch. > @@ -688,11 +688,19 @@ unsigned long native_calibrate_tsc(void) > switch (boot_cpu_data.x86_model) { > case 0x4E: /* SKL */ > case 0x5E: /* SKL */ > + case 0x8E: /* KBL */ > + case 0x9E: /* KBL */ asm/intel-family.h provides proper defines for this. And before you add those, please make a seperate patch which converts the existing hex constants to the defines. Thanks, tglx