From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757399AbcIMNoP (ORCPT ); Tue, 13 Sep 2016 09:44:15 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:58879 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752710AbcIMNoO (ORCPT ); Tue, 13 Sep 2016 09:44:14 -0400 Date: Tue, 13 Sep 2016 15:41:50 +0200 (CEST) From: Thomas Gleixner To: Harry Pan cc: LKML , gs0622@gmail.com, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, peterz@infradead.org, bp@alien8.de, srinivas.pandruvada@linux.intel.com Subject: Re: [PATCH 3/3] perf/x86/rapl: Enable Baytrail/Braswell RAPL support In-Reply-To: <1473571099-1944-3-git-send-email-harry.pan@intel.com> Message-ID: References: <1473571099-1944-1-git-send-email-harry.pan@intel.com> <1473571099-1944-3-git-send-email-harry.pan@intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 11 Sep 2016, Harry Pan wrote: > This patch also enables multiple quirks. This patch adds a single quirk for Baytrail. Please stop sending out patches 5 seconds after a review. Take your time and fixup stuff proper. > +static void rapl_byt_quirk(void) > +{ > + int i; > + > + /* > + * Some Atom processors (BYT/BSW) have 2^ESU microjoules > + * increment, refer to Software Developers' Manual, Vol. 3C, > + * Order No. 325384, Table 35-8 of MSR_RAPL_POWER_UNIT. > + * > + * TODO: In order to fit BYT/BSW quirk model, here remind > + * this generates timer rate in 80ms; by default > + * ESU of BYT/BSW is 5, so it leads (1000/200)*2^4. This sentence is not a sentence and I can't make any sense of it at all. What's the TODO here? And why is that TODO not addressed in this patch? Thanks, tglx