From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1762326AbcINNj0 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Sep 2016 09:39:26 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:34835 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755879AbcINNjY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Sep 2016 09:39:24 -0400
Date: Wed, 14 Sep 2016 15:36:59 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Craig Gallek <kraigatgoog@gmail.com>
cc: David Decotigny <decot@google.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] genirq: Machine-parsable version of
 /proc/interrupts
In-Reply-To: <1473783291-122873-1-git-send-email-kraigatgoog@gmail.com>
Message-ID: <alpine.DEB.2.20.1609141534330.6233@nanos>
References: <1473689534-125511-1-git-send-email-kraigatgoog@gmail.com> <1473783291-122873-1-git-send-email-kraigatgoog@gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 13 Sep 2016, Craig Gallek wrote:
> +What:		/sys/kernel/irq/<irq>/name
> +Date:		September 2016
> +KernelVersion:	4.9
> +Contact:	Craig Gallek <kraig@google.com>
> +Description:	Human-readable flow handler name as defined by the device
> +		driver.

That's ambigous. device driver reads like a the driver of the device which
uses this irq. I fixed that up.

>  static void free_desc(unsigned int irq)
>  {
>  	struct irq_desc *desc = irq_to_desc(irq);
>  
>  	unregister_irq_proc(irq, desc);
> +	kobject_del(&desc->kobj);

You forgot to move this under the sparse lock protection as well. There is
the same race against a concurrent initcall.

Thanks,

	tglx