From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1764914AbcINUfr (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Sep 2016 16:35:47 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:36823 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1762862AbcINUfo (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Sep 2016 16:35:44 -0400
Date: Wed, 14 Sep 2016 22:33:14 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Deepa Dinamani <deepa.kernel@gmail.com>
cc: Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg KH <gregkh@linuxfoundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Theodore Ts'o" <tytso@mit.edu>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        y2038 Mailman List <y2038@lists.linaro.org>
Subject: Re: [PATCH v5 1/5] vfs: Add current_time() api
In-Reply-To: <CABeXuvryJOB-7qr6PG7CC33yW+xh4ADv8=HwXQMZg1eT3ceE4A@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1609142232240.5511@nanos>
References: <1473864486-30862-1-git-send-email-deepa.kernel@gmail.com> <1473864486-30862-2-git-send-email-deepa.kernel@gmail.com> <alpine.DEB.2.20.1609142049340.30349@nanos> <CABeXuvryJOB-7qr6PG7CC33yW+xh4ADv8=HwXQMZg1eT3ceE4A@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 14 Sep 2016, Deepa Dinamani wrote:

> >> + * current_time - Return FS time
> >> + * @inode: inode.
> >> + *
> >> + * Return the current time truncated to the time granularity supported by
> >> + * the fs.
> >> + *
> >> + * Note that inode and inode->sb cannot be NULL.
> >> + * Otherwise, the function warns and returns time without truncation.
> >> + */
> >> +struct timespec current_time(struct inode *inode)
> >
> > Just a nitpick. Can we please rename that to fs_current_time() or something
> > similar which tells right away that this is a FS specific
> > function. current_time() is pretty generic and used in many places as
> > variable/argument name.
> 
> I proposed this as one of the names before:
> https://lkml.org/lkml/2016/6/14/613 .
> But, decided against it because of the inode argument.
> If this is preferred, I will change the patches.
> 
> There are only about 30 (20, outside of staging) current_time
> references outside of Documentation/

It just occured to me and I can live with current_time() as well. Up to Al.

Thanks,

	tglx