mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: linux-kernel@vger.kernel.org, Wanpeng Li <wanpeng.li@hotmail.com>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] x86/apic: Fix suspicious RCU usage in smp_trace_call_function_interrupt
Date: Thu, 15 Sep 2016 10:58:04 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1609151055190.5412@nanos> (raw)
In-Reply-To: <1473920520-12220-1-git-send-email-wanpeng.li@hotmail.com>

On Thu, 15 Sep 2016, Wanpeng Li wrote:
> ---
>  arch/x86/include/asm/apic.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
> index 1243577..71c1fe2 100644
> --- a/arch/x86/include/asm/apic.h
> +++ b/arch/x86/include/asm/apic.h
> @@ -650,8 +650,8 @@ static inline void entering_ack_irq(void)
>  
>  static inline void ipi_entering_ack_irq(void)
>  {
> -	ack_APIC_irq();
>  	irq_enter();
> +	ack_APIC_irq();
>  }

which makes ipi_entering_ack_irq() the same as entering_ack_irq() and
therefor pointless.

Looking further we have the same issue in exiting_ack_irq() where we call
ack_APIC_irq() after irq_exit().

Thanks,

	tglx

  reply	other threads:[~2016-09-15  9:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15  6:22 Wanpeng Li
2016-09-15  8:58 ` Thomas Gleixner [this message]
2016-09-18  8:32   ` Wanpeng Li
2016-09-18 11:35   ` Wanpeng Li
2016-09-19  8:10   ` Peter Zijlstra
2016-10-12 11:07     ` Wanpeng Li
2016-10-12 13:17       ` Thomas Gleixner
2016-10-13 12:19         ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1609151055190.5412@nanos \
    --to=tglx@linutronix.de \
    --cc=kernellwp@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=wanpeng.li@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®