From: Thomas Gleixner <tglx@linutronix.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [GIT pull] irq fixes for 4.8
Date: Mon, 19 Sep 2016 09:16:47 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609190914480.5618@nanos> (raw)
In-Reply-To: <CA+55aFymqNmPa3VAx_o9bsVmEK1T=yNKgyetgbAXTp+eqZ6C3Q@mail.gmail.com>
On Sun, 18 Sep 2016, Linus Torvalds wrote:
> On Sun, Sep 18, 2016 at 1:05 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> >
> > Boris Brezillon (2):
> > genirq: Provide irq_gc_{lock_irqsave,unlock_irqrestore}() helpers
>
> This seems somewhat questionable.
>
> The non-irqsafe versions of these functions have specialized non-SMP
> versions for them. The new ones don't.
>
> I pulled it, because I think it's actually the old versions that are
> garbage (the locking should become a no-op on UP regardless - except
> for the preemption issue which I don't see why it wouldn't be real),
> but I think this is inconsistent and should be fixed (or a comment
> added about why it is ok).
Yes, it lacks a comment. The reason why the non save versions are empty is
that these primitives are solely used in the irq chip hotpath functions. UP
folks wanted to avoid the preempt disable/enable in these anyway interrupt
disabled contexts.
Thanks,
tglx
next prev parent reply other threads:[~2016-09-19 7:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 8:05 Thomas Gleixner
2016-09-18 18:15 ` Linus Torvalds
2016-09-19 7:16 ` Thomas Gleixner [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-09-24 19:21 Thomas Gleixner
2016-08-28 12:20 Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609190914480.5618@nanos \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®