From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754897AbcISJc4 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Sep 2016 05:32:56 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:54447 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752279AbcISJcs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Sep 2016 05:32:48 -0400
Date: Mon, 19 Sep 2016 11:30:24 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Marc Zyngier <marc.zyngier@arm.com>
cc: linux-kernel@vger.kernel.org,
        Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] genirq: Skip chained interrupt trigger configuration if
 type is IRQ_TYPE_NONE
In-Reply-To: <alpine.DEB.2.20.1609191127500.5618@nanos>
Message-ID: <alpine.DEB.2.20.1609191129510.5618@nanos>
References: <1474274967-15984-1-git-send-email-marc.zyngier@arm.com> <alpine.DEB.2.20.1609191111110.5618@nanos> <57DFADB9.4080806@arm.com> <alpine.DEB.2.20.1609191127500.5618@nanos>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 19 Sep 2016, Thomas Gleixner wrote:
> On Mon, 19 Sep 2016, Marc Zyngier wrote:
> > On 19/09/16 10:12, Thomas Gleixner wrote:
> > > On Mon, 19 Sep 2016, Marc Zyngier wrote:
> > >>  	if (handle != handle_bad_irq && is_chained) {
> > >> +		unsigned int type = irqd_get_trigger_type(&desc->irq_data);
> > >> +
> > >>  		/*
> > >>  		 * We're about to start this interrupt immediately,
> > >>  		 * hence the need to set the trigger configuration.
> > >> @@ -828,8 +830,10 @@ __irq_do_set_handler(struct irq_desc *desc, irq_flow_handler_t handle,
> > >>  		 * chained interrupt. Reset it immediately because we
> > >>  		 * do know better.
> > >>  		 */
> > >> -		__irq_set_trigger(desc, irqd_get_trigger_type(&desc->irq_data));
> > >> -		desc->handle_irq = handle;
> > >> +		if (type != IRQ_TYPE_NONE) {
> > >> +			__irq_set_trigger(desc, type);
> > >> +			desc->handle_irq = handle;
> > > 
> > > Are you really sure that the handler should only be set when the trigger
> > > type is != NONE? I seriously doubt that this is correct.
> > 
> > The handler has already been set outside of if() statement (at line
> > 819). Here, we only set it again if we've actually called
> > __irq_set_trigger() which could have changed it to something that takes
> > the type into account (handle_level_irq or handle_edge_irq, for example).
> 
> Ah. I'll add a comment...

Bah. There is one already. Reading patches before being awake seems not to
be a brilliant idea.