From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932570AbcITVir (ORCPT ); Tue, 20 Sep 2016 17:38:47 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:60673 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932351AbcITViq (ORCPT ); Tue, 20 Sep 2016 17:38:46 -0400 Date: Tue, 20 Sep 2016 23:36:10 +0200 (CEST) From: Thomas Gleixner To: Baolin Wang cc: a.zummo@towertech.it, alexandre.belloni@free-electrons.com, rostedt@goodmis.org, mingo@redhat.com, john.stultz@linaro.org, broonie@kernel.org, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [PATCH 1/2] rtc: Add some dummy static inline functions In-Reply-To: <8c570c152c95087faa75e397c667b6d5b8d98b3b.1474177609.git.baolin.wang@linaro.org> Message-ID: References: <8c570c152c95087faa75e397c667b6d5b8d98b3b.1474177609.git.baolin.wang@linaro.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 18 Sep 2016, Baolin Wang wrote: > The patch 2 in this patchset adding tracepoints for alarmtimers will build > failed on S390 platform, due to S390 defconfig did not define CONFIG_RTC_LIB > macro to define the rtc_ktime_to_tm() function which is used in this patch. > Thus we should add some ummy static inline functions in case CONFIG_RTC_LIB > is not defined. I told you before that adding these inlines has the danger that we introduce code which uses these functions in places which does not depend on RTC_LIB. The resulting wreckage is going to be subtle and hard to debug. This still stands and this patch is going nowhere. Thanks, tglx