From: Thomas Gleixner <tglx@linutronix.de>
To: Binoy Jayan <binoy.jayan@linaro.org>
Cc: Carsten Emde <C.Emde@osadl.org>,
"Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Daniel Wagner <daniel.wagner@bmw-carit.de>,
Arnd Bergmann <arnd@arndb.de>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Masami <masami.hiramatsu@linaro.org>,
Mark Brown <mark.brown@linaro.org>
Subject: Re: [RFC PATCH v7 4/5] tracing: Measure delayed hrtimer offset latency
Date: Wed, 21 Sep 2016 17:58:34 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609211720520.5573@nanos> (raw)
In-Reply-To: <CAHv-k__757zY9DAihbFga4bGYnYchw7pTnOc_uKhbd9UB6GYdA@mail.gmail.com>
On Wed, 21 Sep 2016, Binoy Jayan wrote:
> On 20 September 2016 at 19:49, Thomas Gleixner <tglx@linutronix.de> wrote:
> > You still fail to explain why this get_time() magic is required.
>
> Sorry, I missed to address this comment from you. From what I understand
> why the get_time() is needed is to get the more accurate current time
> when the hrtimer base is changed (from the cpu in which it was fired on,
> to the current cpu on which it is currently made to run or restarted)
> wherein the hrtimer base needs to be switched to the new cpu provided
> that it is not running in pinned mode.
Sorry. This has nothing to do with changing the hrtimer_base, simply
because the time base is the same on all cpus.
> Carsten, Could you please comment on that?
It's not Carstens repsonsibility to explain the nature of the change.
You are submitting that code and so it's your job to provide proper
explanations and justifications. If you can't do that, then how do you
think that the review process, which is a feedback loop between the
reviewer and the submitter, should work?
Answer: It cannot work that way. I hope I don't have to explain why.
Thanks,
tglx
next prev parent reply other threads:[~2016-09-21 16:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 13:51 [RFC PATCH v7 0/5] *** Latency histograms *** Binoy Jayan
2016-09-20 13:51 ` [RFC PATCH v7 1/5] tracing: Dereference pointers without RCU checks Binoy Jayan
2016-09-20 13:51 ` [RFC PATCH v7 2/5] tracing: Add hist trigger support for generic fields Binoy Jayan
2016-09-20 13:51 ` [RFC PATCH v7 3/5] tracing: Add preemptirqsoff timing events Binoy Jayan
2016-09-20 13:51 ` [RFC PATCH v7 4/5] tracing: Measure delayed hrtimer offset latency Binoy Jayan
2016-09-20 14:19 ` Thomas Gleixner
2016-09-21 6:06 ` Binoy Jayan
2016-09-21 15:58 ` Thomas Gleixner [this message]
2016-09-22 9:14 ` Binoy Jayan
2016-09-22 17:28 ` Thomas Gleixner
2016-09-22 19:23 ` Mark Brown
2016-09-20 13:51 ` [RFC PATCH v7 5/5] tracing: wakeup latency events and histograms Binoy Jayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609211720520.5573@nanos \
--to=tglx@linutronix.de \
--cc=C.Emde@osadl.org \
--cc=arnd@arndb.de \
--cc=binoy.jayan@linaro.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.brown@linaro.org \
--cc=masami.hiramatsu@linaro.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®