From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933690AbcIVOSc (ORCPT ); Thu, 22 Sep 2016 10:18:32 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:38261 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933331AbcIVOSb (ORCPT ); Thu, 22 Sep 2016 10:18:31 -0400 Date: Thu, 22 Sep 2016 16:16:06 +0200 (CEST) From: Thomas Gleixner To: Arvind Yadav cc: daniel.lezcano@linaro.org, vincent.guittot@linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc In-Reply-To: <1474553366-8400-1-git-send-email-arvind.yadav.cs@gmail.com> Message-ID: References: <1474553366-8400-1-git-send-email-arvind.yadav.cs@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Sep 2016, Arvind Yadav wrote: > Subject: clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc These subject lines are useless and way too long. A patch subject should describe the nature of the patch and not elaborate what the patch is doing technically. clocksrouce/timer-imz-gpt: Prevent resource leaks in error path would be a proper subject line which makes it entirely clear what this patch is about. >>From your subject line I have to read the patch itself to figure that out. It's completely irrelevant whether that resource is a mapping or allocated memory. The point is that the error path leaks resource(s). See Documentation/SubmittingPatches. There you'll find a lengthy explanation about changelogs and summary lines in particular. Thanks, tglx