From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966593AbcIWQn7 (ORCPT ); Fri, 23 Sep 2016 12:43:59 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:42282 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966306AbcIWQn5 (ORCPT ); Fri, 23 Sep 2016 12:43:57 -0400 Date: Fri, 23 Sep 2016 18:41:30 +0200 (CEST) From: Thomas Gleixner To: Arvind Yadav cc: baohua@kernel.org, daniel.lezcano@linaro.org, LKML Subject: Re: [PATCH V3] clocksource/timer-imx-gpt: Preventing resource leakage in error case. In-Reply-To: <1474631874-5777-1-git-send-email-arvind.yadav.cs@gmail.com> Message-ID: References: <1474631874-5777-1-git-send-email-arvind.yadav.cs@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Sep 2016, Arvind Yadav wrote: So last time (V2) you had a almost perfect subject line: clocksrouce/timer-imz-gpt: Prevent resource leaks in error path The only issue was the clocksrcouce typo. Now you made it: clocksource/timer-imx-gpt: Preventing resource leakage in error case. Documentation/SubmittingPatches says: Describe your changes in imperative mood ... as if you are giving orders to the codebase to change its behaviour. "Preventing" is not imperative and the above is not a proper sentence, while the V2 one is. > ret = _mxc_timer_init(imxtm); > - if (ret) > - return ret; > + if (ret) { > + goto error_iounmap; > + } Further Documentation/SubmittingPatches also tells you which tools to use _before_ submission. If you'd used them then the above change would look different. You surely can figure that out yourself. Thanks, tglx