From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933703AbcI3Snt (ORCPT ); Fri, 30 Sep 2016 14:43:49 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:58731 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932875AbcI3Snm (ORCPT ); Fri, 30 Sep 2016 14:43:42 -0400 Date: Fri, 30 Sep 2016 20:41:07 +0200 (CEST) From: Thomas Gleixner To: Paul Burton cc: Marc Zyngier , Jason Cooper , linux-mips@linux-mips.org, Ralf Baechle , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/14] irqchip: i8259: Add domain before mapping parent irq In-Reply-To: <7469373.vRGg21xy4h@np-p-burton> Message-ID: References: <20160919212132.28893-1-paul.burton@imgtec.com> <20160919212132.28893-2-paul.burton@imgtec.com> <7469373.vRGg21xy4h@np-p-burton> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Sep 2016, Paul Burton wrote: > On Monday, 19 September 2016 22:21:18 BST Paul Burton wrote: > > Mapping the parent IRQ will use a virq number which may conflict with > > the hardcoded I8259A_IRQ_BASE..I8259A_IRQ_BASE+15 range that the i8259 > > driver expects to be free. If this occurs then we'll hit errors when > > adding the i8259 IRQ domain, since one of its virq numbers will already > > be in use. > > > > Avoid this by adding the i8259 domain before mapping the parent IRQ, > > such that the i8259 virq numbers become used before the parent interrupt > > controller gets a chance to use any of them. > > Hello, > > Any chance of getting reviews/acks on this & the following 2 patches in the > series so Ralf can take them through the MIPS tree? The lack of these (well, > patches 1 & 2 anyway) blocks applying many of the Malta patches later in the > series. Acked-by: Thomas Gleixner