From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755686AbcJPNbC (ORCPT ); Sun, 16 Oct 2016 09:31:02 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:11733 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752854AbcJPNbB (ORCPT ); Sun, 16 Oct 2016 09:31:01 -0400 X-IronPort-AV: E=Sophos;i="5.31,354,1473112800"; d="scan'208";a="240960554" Date: Sun, 16 Oct 2016 15:30:57 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Siddhi Dave cc: lidza.louina@gmail.com, markh@compro.net, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] Staging: dgnc: Clean up Macros In-Reply-To: <20161016124231.GA18162@siddhi-home-laptop> Message-ID: References: <20161016124231.GA18162@siddhi-home-laptop> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 16 Oct 2016, Siddhi Dave wrote: > Fix checkpatch warning: Macros with flow control statements should be avoided > > Because Macros with flow control statements (goto and return) are > not very nice to read as any flow movement is unexpected. > > Signed-off-by: Siddhi Dave > --- > drivers/staging/dgnc/dgnc_sysfs.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c > index 290bf6e..0767740 100644 > --- a/drivers/staging/dgnc/dgnc_sysfs.c > +++ b/drivers/staging/dgnc/dgnc_sysfs.c > @@ -90,16 +90,16 @@ void dgnc_remove_driver_sysfiles(struct pci_driver *dgnc_driver) > driver_remove_file(driverfs, &driver_attr_pollrate); > } > > -#define DGNC_VERIFY_BOARD(p, bd) \ > - do { \ > - if (!p) \ > - return 0; \ > - \ > - bd = dev_get_drvdata(p); \ > - if (!bd || bd->magic != DGNC_BOARD_MAGIC) \ > - return 0; \ > - if (bd->state != BOARD_READY) \ > - return 0; \ > +#define DGNC_VERIFY_BOARD(p, bd) > +do { > + if (!p) > + return 0; > + > + bd = dev_get_drvdata(p); > + if (!bd || bd->magic != DGNC_BOARD_MAGIC) > + return 0; > + if (bd->state != BOARD_READY) > + return 0; > } while (0) This does not look correct. You are still sort of defining a macro, except that you have dropped all of the \s. A macro has to be defined on a single line, or a line continued with \, so this would cause major syntax errors. I think that someone else worked on similar code and found that some of the tests were also not needed in the context in which this code is used. julia > > static ssize_t vpd_show(struct device *p, struct device_attribute *attr, > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161016124231.GA18162%40siddhi-home-laptop. > For more options, visit https://groups.google.com/d/optout. >