From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758532AbcJQTtK (ORCPT <rfc822;w@1wt.eu>);
        Mon, 17 Oct 2016 15:49:10 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:38318 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755595AbcJQTtJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 17 Oct 2016 15:49:09 -0400
Date: Mon, 17 Oct 2016 21:46:30 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Fenghua Yu <fenghua.yu@intel.com>
cc: "H. Peter Anvin" <h.peter.anvin@intel.com>,
        Ingo Molnar <mingo@elte.hu>, Tony Luck <tony.luck@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Stephane Eranian <eranian@google.com>, Borislav Petkov <bp@suse.de>,
        Dave Hansen <dave.hansen@intel.com>,
        Nilay Vaish <nilayvaish@gmail.com>, Shaohua Li <shli@fb.com>,
        David Carrillo-Cisneros <davidcc@google.com>,
        Ravi V Shankar <ravi.v.shankar@intel.com>,
        Sai Prakhya <sai.praneeth.prakhya@intel.com>,
        Vikas Shivappa <vikas.shivappa@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH v4 12/18] x86/intel_rdt: Add "info" files to resctrl file
 system
In-Reply-To: <1476497548-11169-13-git-send-email-fenghua.yu@intel.com>
Message-ID: <alpine.DEB.2.20.1610172143010.6407@nanos>
References: <1476497548-11169-1-git-send-email-fenghua.yu@intel.com> <1476497548-11169-13-git-send-email-fenghua.yu@intel.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 14 Oct 2016, Fenghua Yu wrote:
>  static int __init rdtgroup_setup_root(void)
>  {
> +	int ret;
> +
>  	rdt_root = kernfs_create_root(&rdtgroup_kf_syscall_ops,
>  				      KERNFS_ROOT_CREATE_DEACTIVATED,
>  				      &rdtgroup_default);
> @@ -193,7 +364,9 @@ static int __init rdtgroup_setup_root(void)
>  	list_add(&rdtgroup_default.rdtgroup_list, &rdt_all_groups);
>  
>  	rdtgroup_default.kn = rdt_root->kn;
> -	kernfs_activate(rdtgroup_default.kn);
> +	ret = rdtgroup_create_info_dir(rdtgroup_default.kn);
> +	if (!ret)
> +		kernfs_activate(rdtgroup_default.kn);
>  
>  	mutex_unlock(&rdtgroup_mutex);

So this is followed by:

   	return 0;

which means that an error in rdtgroup_create_info_dir() is ignored. As a
consequence the mount point is created and the file system is registered
w/o the info directory....

Thanks,

	tglx